Skip to content

chore: update cloudevents dependency to use >=1.2.0 and <2.0.0 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

CorieW
Copy link
Member

@CorieW CorieW commented May 7, 2025

Resolves #234

  • Tested

@CorieW CorieW marked this pull request as draft May 8, 2025 10:27
@CorieW CorieW marked this pull request as ready for review May 15, 2025 00:12
@cabljac cabljac requested a review from Copilot May 19, 2025 10:07
Copy link
Contributor

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the version constraint for the cloudevents dependency to allow any 1.x release from 1.2.0 up to (but not including) 2.0.0.

  • Loosen cloudevents pin from an exact 1.9.0 to a range >=1.2.0,<2.0.0
Comments suppressed due to low confidence (2)

setup.py:20

  • [nitpick] Alphabetize the install_requires list entries to improve readability and make future dependency updates easier to track.
install_requires = [

setup.py:22

  • Lowering the minimum cloudevents version to 1.2.0 may introduce missing features or API changes that were only added in 1.9.0. Consider using >=1.9.0,<2.0.0 to ensure compatibility with existing code.
'pyyaml>=6.0', 'typing-extensions>=4.4.0', 'cloudevents>=1.2.0,<2.0.0',

@taeold taeold merged commit 8a2cce7 into main May 19, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Up cloudevents dependency version to cloudevents<2.0.0 and >=1.2.0
3 participants